[MDEP-648] Add location of listed repository. #50
Conversation
| <dependency> | ||
| <groupId>org.apache.commons</groupId> | ||
| <artifactId>commons-lang3</artifactId> | ||
| <version>3.6</version> |
There was a problem hiding this comment.
Is this related to the functionality that you've implemented?
| <dependency> | ||
| <groupId>org.apache.maven.wagon</groupId> | ||
| <artifactId>wagon-http-lightweight</artifactId> | ||
| <version>3.3.4</version> |
There was a problem hiding this comment.
Is this related to the functionality that you've implemented?
| * Sets whether the plugin runs in verbose mode. As of plugin version 2.3, the default value is derived from Maven's | ||
| * global debug flag (compare command line switch <code>-X</code>). <br/> | ||
| * | ||
| * @since 3.1.2 |
There was a problem hiding this comment.
The @since contradicts the first line of the Javadoc.
|
|
||
| private boolean isVerbose() | ||
| { | ||
| return ( verbose || getLog().isDebugEnabled() ); |
There was a problem hiding this comment.
It's a bit strange that isVerbose checks for log.isDebugEnabled(), while there is a verbose flag already which is triggered (according to its Javadoc) by the -X flag in the CLI.
| this.getLog().info( repo.toString() ); | ||
| String artifactKey = | ||
| ArtifactUtils.key( parent.getGroupId(), parent.getArtifactId(), parent.getVersion() ); | ||
| MavenProject parentPom = getMavenProject( artifactKey ); |
There was a problem hiding this comment.
It seems to me as if you first concatenate groupId, artifactId and version into an artifactKey (line 326), only to pass it to getMavenProject(String) which then uses getArtifactCoordinate to disassemble then into their original values. Why is that?
elharo
changed the title
|
@pmoerenhout thanks also for efforts on it ... we should not use maven-artifact-transfer at all So I close it now. |
|
Resolve #1081 |
4 participants
After maven-artifact-transfer 0.13.0 has been released, the PR will use the new functions from the maven-artifact-transfer to resolve the used repositories, and in verbose mode, also show the (local) location where this repository is defined.