Code cleanup #37
Merged
Code cleanup #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tibor17
reviewed
Mar 8, 2020
| final boolean result = filter.accept( node , Collections.<Node>emptyList() ); | ||
|
|
||
| assertThat( result, is( false )); | ||
| assertFalse( filter.accept( node , Collections.<Node>emptyList() ) ); |
There was a problem hiding this comment.
Can you be more specific?
Tibor17
reviewed
Mar 8, 2020
| ArgumentCaptor<String> captor = ArgumentCaptor.forClass( String.class ); | ||
| verify( log ).debug( captor.capture() ); | ||
| assertThat( captor.getValue(), containsString( "Skipped dependency" ) ); | ||
| MatcherAssert.assertThat( captor.getValue(), containsString( "Skipped dependency" ) ); |
elharo
commented
Mar 21, 2020
slachiewicz
approved these changes
May 23, 2020
pmoerenhout
pushed a commit
to pmoerenhout/maven-dependency-plugin
that referenced
this pull request
Jun 18, 2020
* static import
cosmin
pushed a commit
to cosmin/maven-dependency-plugin
that referenced
this pull request
Nov 24, 2020
* static import
|
Resolve #1254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused variables and deprecated methods
@khmarbaise