-
Notifications
You must be signed in to change notification settings - Fork 182
Open
Labels
bugSomething isn't workingSomething isn't workingpriority:majorMajor loss of functionMajor loss of function
Description
Andreas Sewe opened MDEP-954 and commented
I am using unpack-dependencies
in my project and just got bitten by the following unexpected behaviour:
<includeGroupIds>org.example</includeGroupIds>
includes not just artifacts whose groupId
is {}org.example{
}, but also artifacts whose groupId
is, say, {}org.example.foo{
}.
I consider this a bug for several reasons:
- This is, I believe, inconsistent with how similar
includes
on{}groupId{
}s behave elsewhere in the Maven ecosystem (e.g., in assembly descriptors or enforcer rules). - This is also inconsistent with how
includeArtifactIds
behaves, wheremaven
doesn't matchmaven-core
either. - Last but not least, this makes it quite tricky to target
org.example
andorg.example.foo
by different{}<execution>{
}s ofunpack-dependencies
or{}copy-dependencies{
}. If<includeGroupIds>org.example</includeGroupIds>
comes first, it also processes allorg.example.foo
artifacts, causing the second execution with<includeGroupIds>org.example.foo</includeGroupIds>
to be effectively ignored, as allorg.example.foo
artifacts have already left their trace in thedependency-maven-plugin-markers
directory. (A workaround is careful reordering of the<execution>
elements.)
Hence, please consider changing the interpretation of includeGroupIds
(and {}excludeGroupIds{
}, of course) and possibly also expanding the (sparse) documentation of the property.
Affects: 3.8.0
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingpriority:majorMajor loss of functionMajor loss of function