[MDEP-895] dependency:sources fails for multi-module project

[jira-importer]

Gerd Aschemann opened MDEP-895 and commented

When executing mvn dependency:sources on a multi-module project it fails to retrieve sources for the modules themselves (which is not necessary as the source code is provided locally already):

mvn dependency:sources
...
[INFO] -----< org.apache.maven.its.dependency:tree-multimodule-module-b >------
[INFO] Building MultimoduleTest Module B 1.0-SNAPSHOT                     [3/3]
[INFO]   from module-b/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for MultimoduleTest 1.0-SNAPSHOT:
[INFO]
[INFO] MultimoduleTest .................................... SUCCESS [  0.390 s]
[INFO] MultimoduleTest Module A ........................... SUCCESS [  0.063 s]
[INFO] MultimoduleTest Module B ........................... FAILURE [  0.005 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  0.587 s
[INFO] Finished at: 2023-11-09T10:38:16+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal on project tree-multimodule-module-b: Could not resolve dependencies for project org.apache.maven.its.dependency:tree-multimodule-module-b:jar:1.0-SNAPSHOT: The following artifacts could not be resolved: org.apache.maven.its.dependency:tree-multimodule-module-a:jar:1.0-SNAPSHOT (absent): Could not find artifact org.apache.maven.its.dependency:tree-multimodule-module-a:jar:1.0-SNAPSHOT -> [Help 1]

This is similar to the behaviour of MDEP-409.

A test and PR is already prepared: https://github.com/jmle/maven-dependency-plugin/tree/fix-sources-multimodule

---

Affects: 3.6.1

Issue Links:

• MDEP-900 dependency:resolve fails for multi-module project
  ("is cloned by")
• MDEP-941 Deprecate dependency:sources in favor of dependency:resolve-sources
  ("causes")

Remote Links:

• GitHub Pull Request #349
  

[jira-importer]

Michael Osipov commented

The applied change changes the semantics and contradicts the actual resolve operation. The goal is poorly named. It should have been resolve-sources. We will deprecate this one and create successor.

[jira-importer]

Michael Osipov commented

Reverted with 9fd4ed53b23e35de8ad8179e5b379acf3721ffbe.

[jira-importer]

Elliotte Rusty Harold commented

I think the message is fine. However, it seems reasonable to make

mvnw -N org.apache.maven.plugins:maven-dependency-plugin:3.1.2:get -Dartifact=org.joda:joda-beans:jar:2.8.1

work as well. The other syntax (no :jar) should also work too, of course.