[MCHECKSTYLE-368] Missing test-jar on mvn compile

[jira-importer]

Adam Hornáček opened MCHECKSTYLE-368 and commented

Hello,

we have a multi-module Maven project. One of the subprojects depends on test-jar. Everything seems to work fine until I enable Maven Checkstyle Plugin in this subproject. Then mvn compile target fails; however, mvn package works fine.

The error message:

[ERROR] Failed to execute goal on project opengrok-web: Could not resolve dependencies for project org.opengrok:opengrok-web:war:1.2.1: Failure to find org.opengrok:opengrok:jar:tests:1.2.1 in http://repo.maven.apache.org/maven2/ was cached in the local repository, resolution will not be reattempted until the update interval of maven.org has elapsed or updates are forced -> [Help 1]

PR containing changes that cause this issue:
oracle/opengrok#2259

Thanks.

---

Affects: 3.0.0

Attachments:

• mvn_debug.out (696.84 kB)

[jira-importer]

Michael Osipov commented

Can you please provide debug log output?

[jira-importer]

Adam Hornáček commented

Plugin definition from the top level pom.xml:

<build>
    ...
    <pluginManagement>
        <plugins>
            <plugin>
                <groupId>org.apache.maven.plugins</groupId>
                <artifactId>maven-checkstyle-plugin</artifactId>
                <version>3.0.0</version>
                <dependencies>
                    <dependency>
                        <groupId>com.puppycrawl.tools</groupId>
                        <artifactId>checkstyle</artifactId>
                        <version>8.17</version>
                    </dependency>
                </dependencies>
                <executions>
                    <execution>
                        <id>checkstyle</id>
                        <phase>validate</phase>
                        <configuration>
                            <configLocation>/dev/checkstyle/style.xml</configLocation>
                            <encoding>UTF-8</encoding>
                            <consoleOutput>true</consoleOutput>
                            <failsOnError>true</failsOnError>
                            <suppressionsLocation>/dev/checkstyle/suppressions.xml</suppressionsLocation>
                            <headerLocation>/dev/checkstyle/fileheader.txt</headerLocation>
                            <sourceDirectories>${project.build.sourceDirectory}</sourceDirectories>
                        </configuration>
                        <goals>
                            <goal>check</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>
        </plugins>
    </pluginManagement>
</build>

Dependency that is causing the issue:

<dependency>
    <groupId>${project.groupId}</groupId>
    <artifactId>opengrok</artifactId>
    <version>${project.version}</version>
    <type>test-jar</type>
    <scope>test</scope>
</dependency>

I also uploaded mvn_debug.out file.

Please let me know if you need any other information.

Thanks :)

[jira-importer]

Michael Osipov commented

How do you attach th test classes JAR to the reactor? Is that open source which I can try myself?

[jira-importer]

Adam Hornáček commented

Test jar was added by following the first guide on this page: https://maven.apache.org/plugins/maven-jar-plugin/examples/create-test-jar.html

Yes, it is open source product: https://github.com/oracle/opengrok

Changes that cause the issue: oracle/opengrok#2259

[jira-importer]

Benjamin Marwell commented

Adam Hornáček I see you are not dependent on this feature anymore: oracle/opengrok#2259 (comment)

What is the use case to attach a test-jar anyway? Why would you recycle test classes in another project?