Skip to content

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jun 6, 2023

No description provided.

@elharo elharo changed the title Remove undeclared Guava dependency with Arrays.asList [MBUILDCACHE-60] Remove undeclared Guava dependency with Arrays.asList Jun 6, 2023
@elharo elharo requested a review from olamy June 6, 2023 14:00
@elharo
Copy link
Contributor Author

elharo commented Jun 10, 2023

ping

@olamy
Copy link
Member

olamy commented Jun 11, 2023

ping

why ping?
if CI is green just merge it. You don't need to ask review for such a minor change because it's just modifying test sources not sure you need to ping people to validate this.
I don't mean to be rude. just we don't need too much bureaucracy and judge by ourselves such changes are pretty straightforward and don't need much more validation.

@elharo
Copy link
Contributor Author

elharo commented Jun 17, 2023

I can't agree with that. Code review is essential. If it's that trivial, then it's an easy review. If it isn't, it needs review all the more. I've certainly noticed more than one mistake in Maven when code review was skipped, both by myself and others.

Copy link

@ferdnyc ferdnyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible enough to me.

@ferdnyc
Copy link

ferdnyc commented Jul 13, 2023

I'm with @elharo — I hate merging my own code to a public repo, and will generally only do it if it's a non-code change or I can definitively state that merging won't impact other users.

Otherwise, I figure a second pair of eyes is a sensible precaution on almost any code change, and when there are multiple people with commit access a good general rule is to have someone other than the PR author do the merge. I try to review others' changes as much as I can, in the hopes they'll return the favor.

In that spirit, I've pitched in with an inexpert review of the changes here.

@slachiewicz slachiewicz merged commit 9361858 into master Aug 11, 2023
@slachiewicz slachiewicz deleted the guava branch August 11, 2023 16:18
@jira-importer
Copy link

Resolve #331

1 similar comment
@jira-importer
Copy link

Resolve #331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants