Skip to content

Conversation

olamy
Copy link
Member

@olamy olamy commented Apr 22, 2023

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a MBUILDCACHE JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MBUILDCACHE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MBUILDCACHE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@olamy olamy changed the title Maven 3.9.1 test Run IT test with Maven 3.9.1 Apr 24, 2023
@olamy olamy marked this pull request as ready for review April 24, 2023 10:12
@olamy olamy changed the title Run IT test with Maven 3.9.1 Run IT test with Maven 3.9.1 and 4.0.0-alpha5 Apr 25, 2023
@olamy
Copy link
Member Author

olamy commented Apr 25, 2023

failure cause because of apache/maven-resolver#264

@olamy olamy changed the title Run IT test with Maven 3.9.1 and 4.0.0-alpha5 [MBUILDCACHE-58] document workaround and run IT test with Maven 3.9.1 and 4.0.0-alpha5 Apr 25, 2023
@olamy olamy added the documentation Improvements or additions to documentation label Apr 25, 2023
@olamy olamy changed the title [MBUILDCACHE-58] document workaround and run IT test with Maven 3.9.1 and 4.0.0-alpha5 [MBUILDCACHE-58] document workaround to save cache with 3.9.1 and 4.0.0-alpha-5 and run IT test with Maven 3.9.1 and 4.0.0-alpha5 Apr 25, 2023
@olamy
Copy link
Member Author

olamy commented Apr 26, 2023

could be a better fix with apache/maven-resolver#282

@olamy olamy added bug Something isn't working and removed maintenance labels Apr 26, 2023
olamy added 2 commits April 26, 2023 15:34
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy merged commit 39490fc into master May 5, 2023
@olamy olamy deleted the mvn-3.9.1 branch May 5, 2023 06:00
@Yusufsuryanata1999
Copy link

Yusufsuryanata1999 commented May 20, 2023

Following this checklist to help us incorporate your contribution quickly and easily:

  • [√] Make sure there is a MBUILDCACHE JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • [√] Each commit in the pull request should have a meaningful subject line and body.
  • [√] Format the pull request title like [MBUILDCACHE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MBUILDCACHE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • [√] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [√] Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • [√] You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004 you have to acknowledge this by using the following check-box.

@jira-importer
Copy link

Resolve #301

1 similar comment
@jira-importer
Copy link

Resolve #301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants