Skip to content

Filter the project version into the getting started guide #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2023
Merged

Filter the project version into the getting started guide #70

merged 1 commit into from
Apr 19, 2023

Conversation

bdemers
Copy link
Member

@bdemers bdemers commented Apr 19, 2023 •
edited
Loading

Adding .vm to the end of the file allows interpolating files.

slawekjaranowski
slawekjaranowski requested changes Apr 19, 2023
View reviewed changes
Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Headers like ## Getting Started will be removed from output

https://maven.apache.org/plugins/maven-site-plugin/examples/creating-content.html#common-issues-and-workarounds

@bdemers
Filter the project version into the getting started guide
8d76ffd 
Adding `.vm` to the end of the file allows interpolating files.
@bdemers bdemers force-pushed the filter-version-docs branch from f3d21ba to 8d76ffd Compare April 19, 2023 19:59
@bdemers
Copy link
Member Author

bdemers commented Apr 19, 2023

Thanks, @slawekjaranowski I missed that!

@olamy olamy added the documentation Improvements or additions to documentation label Apr 19, 2023
@olamy olamy merged commit 44a179a into master Apr 19, 2023
@olamy olamy deleted the filter-version-docs branch April 19, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olamy olamy olamy approved these changes

@slawekjaranowski slawekjaranowski slawekjaranowski approved these changes

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bdemers @olamy @slawekjaranowski