Skip to content

Conversation

slawekjaranowski
Copy link
Member

@slawekjaranowski slawekjaranowski commented Nov 4, 2022

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MNG-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MNG-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@slawekjaranowski slawekjaranowski marked this pull request as draft November 4, 2022 07:41
@slawekjaranowski slawekjaranowski force-pushed the fix-tests branch 2 times, most recently from 14b04f4 to 4b7b5fd Compare November 4, 2022 08:35
- IT tests should use separate local repository
- version of tested component should be parameterized
@slawekjaranowski slawekjaranowski changed the title Try to fix it tests [MBUILDCACHE-34] Improve IT test execution Nov 4, 2022
@slawekjaranowski slawekjaranowski marked this pull request as ready for review November 4, 2022 09:22
@slawekjaranowski slawekjaranowski merged commit 5a94bb0 into master Nov 7, 2022
@slawekjaranowski slawekjaranowski deleted the fix-tests branch November 7, 2022 07:56
@jira-importer
Copy link

Resolve #237

1 similar comment
@jira-importer
Copy link

Resolve #237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants