Skip to content

Conversation

@olamy
Copy link
Member

@olamy olamy commented Apr 29, 2025

Signed-off-by: Olivier Lamy olamy@apache.org

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a MBUILDCACHE JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MBUILDCACHE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MBUILDCACHE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy olamy merged commit fcacb62 into apache:master Apr 29, 2025
31 checks passed
@olamy olamy deleted the ghissues branch April 29, 2025 06:25
@github-actions github-actions bot added this to the 1.1.1 milestone Apr 29, 2025
@slawekjaranowski
Copy link
Member

@olamy as you see merged PR are automatically added to current milestone ....
https://github.com/apache/maven-build-cache-extension/milestones

We should manage milestone, current should be 1.2.1

I need to discover how to manage current milestone automatically .... but now we need update manually 😄

@Bukama
Copy link

Bukama commented Apr 29, 2025

@olamy
Copy link
Member Author

olamy commented Apr 29, 2025

LOL @slawekjaranowski see yet another place 🤣

@olamy
Copy link
Member Author

olamy commented Apr 29, 2025

apache/maven-site#772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants