Merged
Conversation
Contributor
Author
|
@elharo since you asked to be tagged; wasn't sure if you all had a Slack channel (or similar system) that lists incoming pull requests across the organization; I'll tag you on the others as well, and thanks again for all the help! |
elharo
approved these changes
Aug 24, 2023
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu Co-authored-by: Moderne <team@moderne.io>
timtebeek
force-pushed
the
refactor/use-diamond-operator
branch
from
f428df7 to
6ea3d73
Compare
Contributor
Author
|
Force pushed the spotless fix. Is there any way for my PRs to skip the manual CI approval? I think that's usually the case when you've previously contributed, but I've not yet seen that with Apache Maven. And is there a better place (such as a shared Slack) where I can discuss such matters? Just looking to help out in the way that causes the least friction; OK if it's not an option to grant me any special privileges! :) |
elharo
approved these changes
Aug 24, 2023
elharo
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on
Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.UseDiamondOperator?organizationId=QXBhY2hlIE1hdmVu