Repository navigation
fix(storage): retry Windows session replacement under read locks - #946
Merged
likun666661 merged 1 commit intoJul 14, 2026
Merged
Conversation
zhiiw
marked this pull request as ready for review
July 14, 2026 03:01
likun666661
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EPERMorEACCESRoot cause
FileSessionStore.updateHeader()safely rewritessession.jsonlthrough a temporary file and atomic rename. On Windows, replacing the destination fails withEPERMwhile another reader briefly hassession.jsonlopen. Session list and preview reads can overlap this header update, so a transient read lock could fail a turn before the provider request was made and surface asmissing_terminal_event.The replacement now retries only the Windows lock-related error codes, with a small bounded backoff. Persistent permission errors still surface after the retry budget; non-Windows behavior remains a single attempt.
Validation
node --test packages/storage/dist/__tests__/session-store.test.js— 40 passednpm run typecheckgit diff --checkThe regression test uses a real Windows file handle rather than mocking the error: the old implementation fails with
EPERM, while the retry succeeds after the reader releases the file.