Repository navigation
refactor(storage): remove the leftover llm-connections.json store #3107
Description
Problem
Connection catalog authority already lives in Runtime Policy (connection-catalog.json). Host bootstrap, config import/export, Desktop, CLI, and Eval all go through that catalog.
FileConnectionStore still maintains a second file, llm-connections.json:
packages/storage/src/connection-store.ts—createConnectionStore/createConnectionStoreForFilepackages/storage/src/relay-profile-store.ts— write helper used only by that storepackages/storage/src/__tests__/connection-store.test.ts
There is no production reader. Host never opens the file. createConnectionStoreForFile has zero callers. The remaining writers are an e2e seeder and a Computer Use script:
apps/desktop/src/main/e2e-fixture/scenarios-settings.tsstill writesllm-connections.jsonscripts/computer-use/real-model.mjsstill copies or creates that file throughcreateConnectionStore
README still documents llm-connections.json as current workspace layout. After #2749 removed connection v1 compatibility, the leftover store cannot migrate or serve old files. Those files are already inert.
This is a second connection authority that product code no longer consults. Keeping it forces tests, scripts, and docs to stay in sync with a dead path.
Desired outcome
One connection file authority: the Runtime Policy catalog. The old store, its export, its tests, and the leftover writers disappear. Existing llm-connections.json files stay on disk as inert user data; Maka does not import them.
Alternatives or workarounds
Keep the store as a silent importer for pre-catalog files. That path has no Host reader today, so it cannot actually import those files.
Acceptance
-
connection-store.ts,relay-profile-store.ts, their tests, and the./connection-storeexport are removed - Desktop e2e
writeConnectionsstops writingllm-connections.json; if a fixture still needs connection rows, it seedsconnection-catalog.json/ the live Runtime Policy writer -
scripts/computer-use/real-model.mjsseeds catalog + credential vault instead ofllm-connections.json - README / README.zh-CN stop listing
llm-connections.jsonas current layout - Repo-wide search shows no production reader or writer of
llm-connections.json - Focused storage, desktop fixture, and script typecheck / Biome pass
Non-goals
- Importing or migrating leftover user
llm-connections.jsonfiles - Changing
connection-catalog.json, credential vault, or Host bootstrap - Replacing the fixture work in Desktop E2E fixtures no longer seed Runtime Host connections #2704 / Desktop E2E fixtures no longer seed Runtime Host connections #2705 (those seed the live catalog; this issue removes the dead store)
Related
- refactor: remove connection v1 compatibility #2749 removed connection v1 compatibility from this store
- Desktop E2E fixtures no longer seed Runtime Host connections #2704 / Desktop E2E fixtures no longer seed Runtime Host connections #2705 seed Runtime Host connections through the live catalog
Verified on main at eea5cd870.
Relevant code:
packages/storage/src/connection-store.tspackages/storage/src/runtime-policy/connection-catalog-document.tspackages/runtime-host/src/server/bootstrap-runtime-policy.tsapps/desktop/src/main/e2e-fixture/scenarios-settings.tsscripts/computer-use/real-model.mjs
This issue was identified during a simplification audit and prepared with AI assistance (Pi / grok-4.6). A human contributor reviewed the analysis and owns the submission.
Activity
1625567290 commentedon Aug 16, 2026
I'm working on this. I'll remove
FileConnectionStore/llm-connections.jsonand its leftover writers. Desktop e2e and the Computer Use script will seed the Runtime Policy catalog instead.Grok is assisting with the implementation; I will review the change and remain the human contributor of record.
简体中文对照
我来处理。删除
FileConnectionStore/llm-connections.json及其残留写入路径。Desktop e2e 和 Computer Use 脚本改为写入 Runtime Policy catalog。Grok 协助实现;我会审阅改动,并作为 human contributor of record。
refactor(storage): remove the leftover llm-connections.json store
refactor(storage): remove the leftover llm-connections.json store (#3117