Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename IndexWriter.NextMerge() to GetNextMerge(), #986 #990

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Rename IndexWriter.NextMerge() to GetNextMerge(), #986 #990

merged 1 commit into from
Oct 23, 2024

Conversation

paulirwin
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Reverts rename of IndexWriter.NextMerge() back to GetNextMerge() to match Java.

Fixes #986

Description

Simple refactor rename for all usages of IndexWriter.NextMerge() to GetNextMerge().

@NightOwl888 NightOwl888 self-requested a review October 23, 2024 19:44
@paulirwin paulirwin merged commit 2054f5f into apache:master Oct 23, 2024
199 checks passed
@paulirwin paulirwin deleted the issue/986 branch October 23, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NightOwl888 NightOwl888 NightOwl888 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Task: Lucene.Net.Index.IndexWriter::NextMerge(): Rename back to GetNextMerge() to align with Java
2 participants
@paulirwin @NightOwl888