BREAKING: Lucene.Net.Spatial Updates #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…packages from Spatial4n.Core and Spatial4n.Core.NTS to Spatial4n.
…e > m_spatialPrefixTree and constructor parameters outerInstance > spatialPrefixTree
…sEnumTransverser: renamed m_outerInstance > m_filter, constructor parameters outerInstance > filter
…d BaseTermsEnumTraverser
…e-nested and renamed GeohashPrefixTreeFactory
…renamed QuadPrefixTreeFactory
…shape fields rather than calling the virtual properties to set them (which can cause initialization issues)
…structors and Reset() method
…es, enabled nullable reference type support
…support; fixed potential NullReferenceException in CompareTo() implementation
…ence type support
…rence type support
…able reference type support. Added missing overload to MakeSPT() with an Assembly parameter for loading types from external assemblies.
…lable reference type support and updated docs
… De-nested VisitorTemplate class and changed protected field m_prefixGridScanLevel to a public property named PrefixGridScanLevel.
…reference type support
…reference type support
…llable reference type support
…e type support and guard clauses
…le reference type support
… reference type support
…rence type support and guard clauses (including AbstractPrefixTreeFilter and AbstractVisitingPrevixTreeFilter constructors)
…rence types and added guard clauses
…ype support and guard clauses
…reference type support
…ference type support and guard clauses
…rence type support and guard clauses
…ference type support and guard clauses
…e support and guard clauses
…lable reference type support and guard clauses
…ence type support and guard clauses
…erence type support and guard clauses
…ype support and guard clauses
…ce type support and guard clauses
…ce type support and guard clauses. Changed SUFFIX_X and SUFFIX_Y to constants.
…pe support and guard clauses
…port and guard clauses
…erence type support and guard clauses
… the project, and removed declaration in individual files
…on > UnsupportedSpatialOperationException to match .NET conventions
|
Awesome! thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spatial4n.CoreandSpatial4n.Core.NTSin a single assembly, as spatial4j does)Lucene.Net.Spatial: Updated namespaces fromSpatial4n.CoretoSpatial4nLucene.Net.Spatial: Updated namespaces fromSpatial4n.Core.Shapes.ImpltoSpatial4n.ShapesLucene.Net.Spatial: Upgraded to new API names in Spatial4nLucene.Net.Spatial: De-Nested public/protected typesLucene.Net.Spatial: Enabled nullable reference type supportLucene.Net.Spatial: Added guard clauses, where appropriate