BREAKING: Lucene.Net.Util.Fst: Added class constraint on all generics #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of long? as it was designed to use reference equality.
…c FST type and reverted to reference equality comparisons.
…ked Next() method obsolete. See apache#279. This change had already been done to BytesRefFSTEnum, which made them inconsistent.
NightOwl888
force-pushed
the
feature/fst-reference-types
branch
from
26d65f2
to
de893b9
Compare
NightOwl888
added a commit
that referenced
this pull request
Dec 20, 2021
#581) (#583) * BREAKING: Lucene.Net.Queries.Function.ValueSources.EnumFieldSource: Removed nullable value types from public API * Lucene.Net.Queries: Removed unnecessary nullable value types * SWEEP: Removed several unnecessary nullable value type declarations in the test framework and in tests * BREAKING: Lucene.Net.QueryParsers.Flexible: Removed unnecessary nullable value types from ConfigurationKeys and configuration setters/getters in StandardQueryParser. Added AbstractQueryConfig.TryGetValue() method to allow retrieving value types so they can be defaulted properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts
Lucene.Net.Util.Fstto be more like the original design, using reference types as the generic closing type for generic classes and methods. It reverts to the original reference equality checking that Lucene uses. It also adds a class constraint on all of the generic types to enforce this, as using value types is incompatible with the reference equality checks.The original design of FST uses reference equality to compare output values. There are also extensions to FST in
Lucene.Net.Miscthat declare the generic type asobjectso either a long integer type or another reference type can be returned.This had been changed to use
long?as the generic closing type and the reference equality checking was changed to value equality checking. This of course meant that boxing would take place in theLucene.Net.Miscextensions and also made it impossible to uselonginstead oflong?as the generic closing type because of how equality was being compared, which made the API confusing to use.This PR also adds a
MoveNext()method to theLucene.Net.Util.Fst.Int32sRefFSTEnumand deprecates theNext()method (see #279).