BUG: Lucene.Net.QueryParser.Flexible.Standard: Fixed calendar handling on .NET Core #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…: Fixed support for non-Gregorian calendars, which were causing random failures in Lucene.Net.QueryParser.Flexible.Standard.TestNumericQueryParser. Also added TODOs about fixing time zone.
…: Added bounds checks for random date generation to ensure they are within the range of the test culture's calendar.
…le.Standard.Config.NumberDateFormat: Widened constructors to use IFormatProvider instead of CultureInfo and changed Culture property to FormatProvider. Added support for time zones to NumberDateFormat.
…: Write out formatter output for debug purposes.
…lify time zone conversions.
NightOwl888
force-pushed
the
fix/queryparser-numberdateformat
branch
from
1488fc3
to
3f1f368
Compare
…xed const initialization order
…e TimeZoneInfo during parsing and when selecting random dates
…::BeforeClass(): Corrected date format string to explicitly specify era and to include minutes in the time zone offset, which was preventing round-tripping from working correctly.
…e full time zone (including minutes) for FULL time
…ded support for converting unspecified time zones to the specified time zone + tests.
…d nullable warnings
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lucene.Net.Util.NumberFormatandLucene.Net.QueryParsers.Flexible.Standard.Config.NumberDateFormatto acceptIFormatProviderrather thanCultureInfoand changedNumberFormat.Cultureproperty toNumberFormat.FormatProvider.