Bug Fix: Re-ported ControlledRealTimeReopenThread and added 2 new tests #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two additional demonstration tests for ControlledRealTimeReopenThread that make it easier to see how to use the class. One of the tests, TestMultithreadedWaitForGeneration, demonstrates that the current implemention of the ControlledRealTimeReopenThread class is flawed when used in multi-thread situations. This test will fail currently but I will then add another commit that improves the ControlledRealTimeReopenThread class so that it's a more faithful port of the java version and then the test will pass.
The exising port of ControlledRealTimeReopenThread exhibited threading issues. I constructed a test TestMultithreadedWaitForGeneration which demonstrated the threading issue and falls with the curent port class. To make this test pass I re-ported the ControlledRealTimeReopenThread to more faithly follow the java implementation.
NightOwl888
requested changes
Aug 18, 2021
| /// </summary> | ||
| public void Dispose() | ||
| { | ||
| Dispose(true); |
There was a problem hiding this comment.
This class is not sealed. We should keep the dispose pattern in place so inheritors have a way to dispose any unmanaged resources that they own and so the finalizer doesn't automatically run.
It would also be wise to keep track of whether Dispose(bool) has been called so it is safe to call it more than once. See https://stackoverflow.com/a/5306896. Also, please include tests for multiple-dispose.
There was a problem hiding this comment.
Ok, I'll add back a Dispose(bool) method.
Added back a Dispose(bool) method to the ControlledRealTimeReopenThread class since it's a non-sealed class.
rclabo
changed the title
NightOwl888
added a commit
that referenced
this pull request
Dec 15, 2021
…te changes from #513 (#572) * Revert "Revert "Bug Fix: Re-ported ControlledRealTimeReopenThread and added 2 new tests"" This reverts commit 60aef3a. * Lucene.Net.Search.ControlledRealTimeReopenThread: Updated to use Time.SecondsPerNanosecond and Time.MillisecondsPerNanosecond constants rather than literals * Lucene.Net.Search.ControlledRealTimeReopenThread: Made Dispose() lockless and made refreshStartGen and isDisposed atomic * Lucene.Net.Index.ThreadedIndexingAndSearchingTestCase::RunTest(): use using block on LineFileDocs to ensure it is disposed. * Lucene.Net.Search.TestControlledRealTimeReopenThread: Ignore TestStraightForwardDemonstration() and TestMultiThreadedWaitForGeneration(), since they don't play well with other tests due to precision timing * Lucene.Net.Index.ThreadedIndexingAndSearchingTestCase: Use ConucurrentSet<T> rather than ConcurrentHashSet<T>. The latter may have problems with its UnionWith() method. * Lucene.Net.Search.ControlledRealTimeReopenThread: Marked wait handle protected and renamed m_signal so subclasses can receive events * Lucene.Net.Search.ControlledRealTimeReopenThread: Renamed member variable from m_signal to m_notify for clarity * Revert "Lucene.Net.Index.ThreadedIndexingAndSearchingTestCase: Use ConucurrentSet<T> rather than ConcurrentHashSet<T>. The latter may have problems with its UnionWith() method." This reverts commit a93a4a3. * Lucene.Net.Index.IndexReader::Dispose(): Added missing call to GC.SuppressFinalize(this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two additional demonstration tests for ControlledRealTimeReopenThread that make it easier to see how to use the class. One of the tests, TestMultithreadedWaitForGeneration, demonstrates that the current implemention of the ControlledRealTimeReopenThread class is flawed when used in multi-thread situations. This test will fail currently but I will then add another commit that improves the ControlledRealTimeReopenThread class so that it's a more faithful port of the java version and then the test will pass.