Fix for code analyzer support on Visual Studio 2017 (fixes #394) #467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #394.
This downgrades our code analyzers from .NET Standard 2.0 to .NET Standard 1.3 to fix analyzer loading issues in Visual Studio 2017 when referencing the
Lucene.Net
NuGet package.It also downgrades
Microsoft.CodeAnalysis.CSharp.Workspaces
andMicrosoft.CodeAnalysis.VisualBasic.Workspaces
to 2.6.1 and adds direct dependencies onMicrosoft.CodeAnalysis.CSharp
andMicrosoft.CodeAnalysis.VisualBasic
. There is an unofficial guide that describes how this versioning works, but this should add support for Visual Studio 15.6.1 and higher (previously it was 16.4.0 and higher).The patch was confirmed to work on Visual Studio 15.9.29 as well as Visual Studio 16.8.2 in both C# and Visual Basic.
A
Version.props
file was also added so we can manually bump the binary version (version revision only) whenever a change is made, which is a requirement of Visual Studio to be able to reload an analyzer. This will prevent workarounds like #286 (comment) from being necessary, and helps to ensure we are verifying the correct copy when debugging.References