Fixes CLI index page versioning issue (Fixes #416) #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a fenced code block by updating the lucene-cli index file in Powershell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416.
This works around the problem that DocFx has updating tokens within fenced code blocks by doing the replacement before calling DocFx using Powershell.
I left the change to the version in the document, as the logical time to update it is when there is a release, so we just need to commit it back to the repo (we can automate this, but should start using a release branching scheme first so it doesn't happen live on
master).Also removed duplication of setting the environment variable and added regex validation to the version number.