Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine why Term is null in TestDocTermOrds when using SeekExact(0) #405

Closed
NightOwl888 opened this issue Jan 29, 2021 · 5 comments · Fixed by #415
Closed

Determine why Term is null in TestDocTermOrds when using SeekExact(0) #405

NightOwl888 opened this issue Jan 29, 2021 · 5 comments · Fixed by #415
Assignees
@rclabo
Labels
investigation pri:normal
Milestone
4.8.0-beta00014

Comments

@NightOwl888
Copy link
Contributor

This change diverges from Java Lucene and shouldn't be necessary.

We run tests in Release mode with Verbose set to false, so in that case the problem is skipped. However, in Debug mode the problem crops up. We need to investigate why Term is sometimes null and formulate a fix.
@NightOwl888 NightOwl888 added up-for-grabs This issue is open to be worked on by anyone investigation good-first-issue Good for newcomers pri:normal labels Jan 29, 2021
@NightOwl888 NightOwl888 added this to the 4.8.0 milestone Jan 29, 2021
@NightOwl888
Copy link
Contributor Author

NightOwl888 commented Jan 30, 2021 •
edited
Loading

I suspect that 11323a5 might be where this problem began occurring.

@rclabo
Copy link
Contributor

rclabo commented Feb 1, 2021

I'll do this one

@NightOwl888
Copy link
Contributor Author

Great. I have assigned the issue to you. Thanks.

@rclabo
Copy link
Contributor

rclabo commented Feb 2, 2021

It seems like the commit for this change got rolled back since it does not appear in the commit history for TestDocTermOrds. Is that a valid understanding? If so, is there any way in GitHub to actually confirm the commit was applied on date A but rolled back on date B? Or is there some other explanation for not seeing that commit in the commit history? (Sorry for these kinds of basic questions, I'm still working on better understanding GitHub )

@NightOwl888
Copy link
Contributor Author

I apologize, I should have specified that the change is from PR #381 that hasn't been merged to master.

@NightOwl888 NightOwl888 removed good-first-issue Good for newcomers up-for-grabs This issue is open to be worked on by anyone labels Feb 4, 2021
@NightOwl888 NightOwl888 linked a pull request Feb 6, 2021 that will close this issue
Fixed bug that was causing test to fail. #415
Merged
NightOwl888 pushed a commit that referenced this issue Feb 6, 2021
@rclabo
BUG: Lucene.Net.Index.DocTermOrds: Fixed broken MoveNext() return val…
e8d64d6 
…ue in OrdWrappedTermsEnum class (fixes #405)
@NightOwl888 NightOwl888 mentioned this issue Feb 6, 2021
Closed
@NightOwl888 NightOwl888 modified the milestones: 4.8.0, 4.8.0-beta00014 Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rclabo rclabo

Labels
investigation pri:normal
Projects
None yet
Milestone
4.8.0-beta00014
Development

Successfully merging a pull request may close this issue.

Fixed bug that was causing test to fail.
2 participants
@NightOwl888 @rclabo