Lucene.Net.QueryParser.Flexible.Standard.Processors: Changed numeric …

…processors back to using FormatException, because that is the expected parse error in .NET (see #446)
apache · Apr 26, 2021 · 2b278b3 · 2b278b3
1 parent f7eac9d
commit 2b278b3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Lucene.Net.QueryParser/Flexible/Standard/Processors/NumericQueryNodeProcessor.cs b/src/Lucene.Net.QueryParser/Flexible/Standard/Processors/NumericQueryNodeProcessor.cs
@@ -89,7 +89,7 @@ protected override IQueryNode PostProcessNode(IQueryNode node)
                                 {
                                     number = numberFormat.Parse(text);
                                 }
-                                catch (Exception e) when (e.IsParseException())
+                                catch (FormatException e) // LUCENENET: In .NET we are expecting the framework to throw FormatException, not ParseException
                                 {
                                     throw new QueryNodeParseException(new Message(
                                         QueryParserMessages.COULD_NOT_PARSE_NUMBER, fieldNode

diff --git a/src/Lucene.Net.QueryParser/Flexible/Standard/Processors/NumericRangeQueryNodeProcessor.cs b/src/Lucene.Net.QueryParser/Flexible/Standard/Processors/NumericRangeQueryNodeProcessor.cs
@@ -87,7 +87,7 @@ protected override IQueryNode PostProcessNode(IQueryNode node)
                                 {
                                     lowerNumber = numberFormat.Parse(lowerText);
                                 }
-                                catch (Exception e) when (e.IsParseException())
+                                catch (FormatException e) // LUCENENET: In .NET we are expecting the framework to throw FormatException, not ParseException
                                 {
                                     throw new QueryNodeParseException(new Message(
                                         QueryParserMessages.COULD_NOT_PARSE_NUMBER, lower
@@ -101,7 +101,7 @@ protected override IQueryNode PostProcessNode(IQueryNode node)
                                 {
                                     upperNumber = numberFormat.Parse(upperText);
                                 }
-                                catch (Exception e) when (e.IsParseException())
+                                catch (FormatException e) // LUCENENET: In .NET we are expecting the framework to throw FormatException, not ParseException
                                 {
                                     throw new QueryNodeParseException(new Message(
                                         QueryParserMessages.COULD_NOT_PARSE_NUMBER, upper