Add analyzer and code fix for public types in Lucene.Net.Support, #1100

[paulirwin]

NOTE: This requires #1 to be merged first, as it is a stacked PR on top of that one, so it shows all changes from that PR as well. I will rebase it against main once #1 is merged.

This adds a diagnostic and code fix for detecting public types in the Lucene.Net.Support namespace.

Partial apache/lucenenet#1100 (Will still need to add these analyzers to Lucene.NET in order to close that issue)

[NightOwl888]

Thanks. This looks pretty good.

However, we are still figuring things out, so I left some comments on some of these issues. Do note that some of them are not directly related to this PR, so they could be made into new issues.

I noticed that we are getting build warnings for the AnalyzerReleases.Shippped.md file containing invalid version numbers. Apparently, the tool doesn't support pre-release numbers.

https://chatgpt.com/share/68d915a1-9d28-8005-8ee4-b0934776fdaf

So, for sure we need to change the Git commit hook to only put the major and minor components of the version into the file. We may also consder moving these back into "Unshipped" state until the official 1.0 release. It sounds like we should only be updating that doc when the production version number changes or alternatively, migrate all new rules into the 1.0 release as each pre-release is shipped and create a new section only for the next production release.

Whatever direction we go, we will need to update the make-release.md document with the new info.

[NightOwl888]

Let's also fix the Git commit hook so it only uses the major and minor version to match the expectations of the AnalyzerReleases spec. It is located at:

lucenenet-codeanalysis-dev/eng/git-hooks/post-commit

Line 60 in 9479165

version=$(nbgv get-version -v NuGetPackageVersion)

The nbgv command to use to get the major and minor version and ignore the rest is:

nbgv get-version -v MajorMinorVersion

Also, we should update the make-release.md file to reflect that change in the example.

[NightOwl888]

I gave it a try to see if it works in Lucene.NET using the latest build from CI. It didn't update automatically until I restarted Visual Studio to reload the cache. Most likely because we didn't bump to 1.1 yet.

The analyzer seems to be working well, but when I try the code fix, it strips the license header from the file.

---

The comments are stored in the LeadingTrivia of the code element (which returns a SyntaxTriviaList). That list needs to be carried over into the updated node unchanged.

[NightOwl888]

Come to think of it, there is also a TrailingTrivia element. But, I have no idea what the effect of removing it would be or even if changing the modifiers of a class would remove it.

[paulirwin]

Fixed issue with leading/trailing trivia including added unit test coverage.