Repository navigation
Conversation
dweiss
approved these changes
Oct 7, 2026
Contributor
|
Does it apply to 10x? Please set the milestone too. |
Contributor
Author
|
Yes, the TaskExecutor in I cannot set any labels/milestones in GitHub though, if you're referring to that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Our test infra uncovered this one, even though it is not reproducible with a specific seed. Repro line was and it failed here
To my understanding
shouldExitcan be called with with TaskExecutor, so decrementing the integer is not safe in this case.