Repository navigation
Conversation
epotyom
approved these changes
Oct 7, 2026
epotyom
left a comment
epotyom
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, thanks for the fix!
| DirectoryTaxonomyReader taxoReader = new DirectoryTaxonomyReader(dir); | ||
| taxoReader.getBulkOrdinals(a, b); // fills the ordinal cache | ||
| // all ordinals are cached now, so the lookup must not touch the index reader at all | ||
| taxoReader.getInternalIndexReader().close(); |
| * GITHUB#16667: Rewrite BooleanQuery to MatchNoDocsQuery when it has MUST_NOT clause matching one of | ||
| its MUST boost or constant score query clauses. (Egor Potemkin) | ||
|
|
||
| * GITHUB#XXXXX: DirectoryTaxonomyReader#getBulkOrdinals now returns early when every requested label |
Contributor
There was a problem hiding this comment.
Please replace with real PR id!
…ll-cached # Conflicts: # lucene/CHANGES.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was exploring the code with Claude and found that
DirectoryTaxonomyReader#getBulkOrdinalshas an early return for the case where every requested label is already in the ordinal cache, but that early return never triggered.The condition for early return checks
indexesMissingFromCache.length == 0, which is the capacity of the miss array (Math.min(10, categoryPaths.length)), not the number of misses. Calls with fewer than two labels return before this point, so the capacity here is always at least 2.As a result, a fully cached call still sorts an empty array and creates a
TermsEnumover all taxonomy segments. The returned ordinals were always correct, it it just an optimization.