Repository navigation
Add fp16 support to the diversifying children KNN query - #16738
Merged
Merged
Conversation
kaivalnp
reviewed
Sep 30, 2026
kaivalnp
left a comment
kaivalnp
left a comment
Contributor
There was a problem hiding this comment.
Nice! The new class is very similar to the float32 equivalent. Added small comments.
kaivalnp
approved these changes
Sep 30, 2026
…torSimilarityQuery.java
kaivalnp
reviewed
Oct 1, 2026
| * @param searchStrategy the search strategy to use. If null, the default strategy will be used. | ||
| * The underlying format may not support all strategies and is free to ignore the requested | ||
| * strategy. | ||
| * @lucene.experimental |
Contributor
There was a problem hiding this comment.
Pre-existing, but I think this belongs in the javadocs of the class and not the constructor?
This can be fixed in a follow-up PR though.
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Solves a task of #16725
We have been adding FP16 vector encoding support to Lucene 11. This PR adds FP16 support to the parent-block-join diversifying kNN query, which joins matching children vector documents with their parent doc id during kNN search.