Skip to content

Rename CollectionStatistics to FieldStats and TermStatistics to TermStats.#15929

Open
vsop-479 wants to merge 9 commits intoapache:mainfrom
vsop-479:rename_CollectionStatistics2FieldStatistics
Open

Rename CollectionStatistics to FieldStats and TermStatistics to TermStats.#15929
vsop-479 wants to merge 9 commits intoapache:mainfrom
vsop-479:rename_CollectionStatistics2FieldStatistics

Conversation

@vsop-479
Copy link
Copy Markdown
Contributor

@vsop-479 vsop-479 commented Apr 3, 2026

No description provided.

@github-actions github-actions bot added this to the 11.0.0 milestone Apr 7, 2026
Copy link
Copy Markdown
Contributor

@jainankitk jainankitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without any context around why it was called CollectionStatistics, this change makes sense to me. Although, I am wondering if we should rename the corresponding methods and parameters as well to be inline with this change?

@vsop-479
Copy link
Copy Markdown
Contributor Author

vsop-479 commented Apr 8, 2026

Thanks @jainankitk ! I will do it.

@vsop-479 vsop-479 requested review from jainankitk and rmuir April 9, 2026 05:47
@rmuir
Copy link
Copy Markdown
Member

rmuir commented Apr 14, 2026

I don't remember the reasoning behind the name, but I think FieldStatistics is better.

One thing to consider, we also have NumericFieldStats class. Maybe we want to think about more consistency and shorter names? e.g. FieldStats/TermStats/NumericFieldStats ?

Would just not be great to have to rename it yet again.

@vsop-479
Copy link
Copy Markdown
Contributor Author

One thing to consider, we also have NumericFieldStats class. Maybe we want to think about more consistency and shorter names? e.g. FieldStats/TermStats/NumericFieldStats ?

Makes sense, I will rename FieldStatistics to FieldStats, and TermStatistics to TermStats.

@vsop-479 vsop-479 changed the title Rename CollectionStatistics to FieldStatistics. Rename CollectionStatistics to FieldStats. Apr 15, 2026
@vsop-479 vsop-479 changed the title Rename CollectionStatistics to FieldStats. Rename CollectionStatistics to FieldStats and TermStatistics to TermStats. Apr 15, 2026
@vsop-479
Copy link
Copy Markdown
Contributor Author

I also added an entry in MEGRATE.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants