Skip to content

Add a linter flag to suppress warning about incubating vector module. #14802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −3
Open

Add a linter flag to suppress warning about incubating vector module. #14802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions build-tools/build-infra/src/main/groovy/lucene.java.tests-and-randomization.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,17 @@ if (verboseMode && !verboseModeHookInstalled) {
}
}

Provider<Integer> minMajorVersion = upperJavaFeatureVersionOption.map { ver -> Integer.parseInt(JavaVersion.toVersion(ver).majorVersion) }
JavaVersion runtimeJava = rootProject.ext.runtimeJavaVersion
boolean incubatorJavaVersion = rootProject.ext.vectorIncubatorJavaVersions.contains(runtimeJava)

// if the vector module is in incubator, pass lint flags to suppress excessive warnings.
if (incubatorJavaVersion) {
tasks.withType(JavaCompile).configureEach {
it.options.compilerArgs += ["-Xlint:-incubating"]
}
}

tasks.withType(Test).configureEach {
// Running any test task should first display the root randomization seed.
dependsOn ":showTestsSeed"
Expand Down Expand Up @@ -225,9 +236,6 @@ tasks.withType(Test).configureEach {

// Enable the vector incubator module on supported Java versions:

Provider<Integer> minMajorVersion = upperJavaFeatureVersionOption.map { ver -> Integer.parseInt(JavaVersion.toVersion(ver).majorVersion) }
JavaVersion runtimeJava = rootProject.ext.runtimeJavaVersion
boolean incubatorJavaVersion = rootProject.ext.vectorIncubatorJavaVersions.contains(runtimeJava)
boolean manualMinMajorVersion = minMajorVersion.isPresent() &&
Integer.parseInt(runtimeJava.majorVersion) <= minMajorVersion.get()
if (incubatorJavaVersion || manualMinMajorVersion) {
Expand Down