[Build] Fix more gradle deprecation warnings scheduled to be removed in 9.0 #14783
Conversation
Resolution of the configuration :icu_current was done from a context different than the root project. This is problematic and deprecated behavior scheduled to be removed in Gradle 9.0. See https://docs.gradle.org/8.14/userguide/how_to_share_outputs_between_projects.html\#variant-aware-sharing for details how dependencies should be shared accross projects.
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
| @@ -30,14 +30,15 @@ def resources = rootProject.file("gradle/regenerate/icu") | |||
| * download and compile a matching icu4c version automatically. | |||
| */ | |||
|
|
|||
| // Configure different icu4j dependencies. | |||
| configure(rootProject) { | |||
There was a problem hiding this comment.
Declaring a configuration in one project and use it in another as done here before was one. of those things that had been technically possible forever, never recommended and now been deprecated. A good example of the problem with the historical approach in Gradle that in build logic there hasn't been any boundaries accross projects and the whole global model has been available from everywhere.
There was a problem hiding this comment.
IMO this plugin is a good example of something that can benefit from been ported into a binary plugin and only keep its actual implementation in this convention plugin rather all the nitty bits of implementation details.
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
github-project-automation
bot
moved this from Open
to Merged
in OpenSearch Lucene & Core Performance Tracking
Description
This fixes three more types of deprecations seen in the build:
Resolution of the configuration :icu_current was done from a context different than the root project.
This is problematic and deprecated behavior scheduled to be removed in Gradle 9.0.
See https://docs.gradle.org/8.14/userguide/how_to_share_outputs_between_projects.html\#variant-aware-sharing for details how dependencies should be shared accross projects.