Convert more PriorityQueues to use Comparator #14761
Conversation
github-project-automation
bot
moved this to Open
in OpenSearch Lucene & Core Performance Tracking
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
| class SpanPositionQueue extends PriorityQueue<Spans> { | ||
| SpanPositionQueue(int maxSize) { | ||
| super(maxSize); // do not prepopulate | ||
| public interface FloatComparator { |
There was a problem hiding this comment.
There are no JCL methods to compare floats without converting them to doubles first, so this enables direct float comparisons. The interface compare method isn't actually used here, but it seems remiss to not have a FloatComparator interface without a compare method defined.
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
| @@ -92,7 +93,22 @@ public SloppyPhraseMatcher( | |||
| this.slop = slop; | |||
| this.numPostings = postings.length; | |||
| this.captureLeadMatch = captureLeadMatch; | |||
| pq = new PhraseQueue(postings.length); | |||
| pq = | |||
| PriorityQueue.usingLessThan( | |||
There was a problem hiding this comment.
Changing this to a Comparator did have an effect on performance, so keeping with the lessThan implementation here
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
thecoop
force-pushed
the
priority-queue-more-comparators
branch
from
63eff0b to
5765b34
Compare
|
This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog label to it and you will stop receiving this reminder on future updates to the PR. |
Following on from #14705, convert some more
PriorityQueues to use Comparator. This still leaves several complicated and public API subclasses ofPriorityQueue