Add support for querying multiple fields to QueryBuilder. #14262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`QueryBuilder#createBooleanQuery` now supports querying multiple fields. Scoring-wise, it supports two options: either BM25F, the best choice but requires fields to be indexed/searched with the same analyzer, index options and similarity, or taking the max score across fields, a poor option but that doesn't make any assumption about how fields are indexed/searched. To make it work properly, I added support for multiple terms back to `CombinedFieldQuery` (like in sandbox) to support synonyms.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QueryBuilder#createBooleanQuerynow supports querying multiple fields. Scoring-wise, it supports two options: either BM25F, the best choice but requires fields to be indexed/searched with the same analyzer, index options and similarity, or taking the max score across fields, a poor option but that doesn't make any assumption about how fields are indexed/searched.To make it work properly, I added support for multiple terms back to
CombinedFieldQuery(like in sandbox) to support synonyms.