Skip to content

PriorityQueue.remove should be removed or improved #15309

@dweiss

Description

@dweiss

Description

This method is counterintuitive in that:

  • it compares the argument by reference, not by .equals
  • it does a linear scan through all elements of the pq (it is costly)

This method is also used in one place within Lucene. Maybe we should just look at an alternative where it's currently used and drop remove without replacement?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions