LUCENE-9687: Hunspell suggestions: reduce work in the findSimilarDictionaryEntries loop #2451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ionaryEntries loop The loop is called a lot of times, and some allocations and method calls can be spared
|
Sorry, I couldn't create a separate JIRA issue for this change due to some "XSRF Security Token Missing" error in JIRA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The loop is called a lot of times, and some allocations and method calls can be spared
Solution
Extract some code outside the loop
Tests
No new tests, ~5% speedup in
TestPerformance.en_suggestChecklist
Please review the following and check all that apply:
masterbranch../gradlew check.