LUCENE-9787: Hunspell: speed up suggesting a bit by not creating a huge TreeSet #2400
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We only need 100 first elements, not need to compare the thousands of other roots among themselves
Solution
Use a PriorityQueue, trim it once it becomes larger then the limit
Tests
Nothing failing, but added suggestion checks in
TestPerformance
to track progress. For now suggesting is horribly slow :(Checklist
Please review the following and check all that apply:
master
branch../gradlew check
.