Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-9787: Hunspell: speed up suggesting a bit by not creating a huge TreeSet #2400

Merged
merged 1 commit into from
Feb 19, 2021
Merged

LUCENE-9787: Hunspell: speed up suggesting a bit by not creating a huge TreeSet #2400

merged 1 commit into from
Feb 19, 2021

Conversation

donnerpeter
Copy link
Contributor

Description

We only need 100 first elements, not need to compare the thousands of other roots among themselves

Solution

Use a PriorityQueue, trim it once it becomes larger then the limit

Tests

Nothing failing, but added suggestion checks in TestPerformance to track progress. For now suggesting is horribly slow :(

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the master branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Ref Guide (for Solr changes only).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants