-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SOLR-8138: Simple UI for issuing SQL queries #2381
Conversation
This code was mostly written by Michael Suzuki, i just tweaked it to load, and updated the version of ui-grid to th 4.10 version.
@michaelsuzukisagi I'd love your review. |
I think I'm done with this PR! I'd love a review and then I'll commit it. I could see backporting it to 8.x as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do we need to add a short credit to ui-grid in LICENSE.txt? I'm confused about when to use NOTICE and LICENSE, but I think it should go in one of them?
are you referring to the Be nice to add this to the dev docs! |
also, I don't see any licenses for the JS libraries.... |
How do we get a clarificaiton on this? |
So I think you add a few lines at bottom of |
ahh! I didn't know abouit that! |
This code was mostly written by Michael Suzuki in PR #180, i just tweaked it to load in Solr 9, and updated the version of ui-grid to the 4.10 version.
Description
Add a simple page to Solr Admin for doing SQL queries.
Solution
Delegates to the
qt=sql
handler and runs the query. Displays results in basic table.This UI shows how easy it is to write a SQL query that Solr doesn't like ;-(. However, it's much easier to use than using Curl. And may encourage more use of this powerful feature.
Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
Checklist
Please review the following and check all that apply:
master
branch../gradlew check
.