Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-8138: Simple UI for issuing SQL queries #2381

Merged
merged 9 commits into from
Feb 18, 2021

Conversation

epugh
Copy link
Contributor

@epugh epugh commented Feb 16, 2021

This code was mostly written by Michael Suzuki in PR #180, i just tweaked it to load in Solr 9, and updated the version of ui-grid to the 4.10 version.

Description

Add a simple page to Solr Admin for doing SQL queries.

Solution

Delegates to the qt=sql handler and runs the query. Displays results in basic table.

This UI shows how easy it is to write a SQL query that Solr doesn't like ;-(. However, it's much easier to use than using Curl. And may encourage more use of this powerful feature.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

Checklist

Please review the following and check all that apply:

  • [X ] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • [ X] I have created a Jira issue and added the issue ID to my pull request title.
  • [ X] I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • [X ] I have developed this patch against the master branch.
  • [ X] I have run ./gradlew check.
  • I have added tests for my changes.
  • [X ] I have added documentation for the Ref Guide (for Solr changes only).

This code was mostly written by Michael Suzuki,  i just tweaked it to load, and updated the version of ui-grid to th 4.10 version.
@epugh epugh requested a review from janhoy February 16, 2021 19:24
@epugh
Copy link
Contributor Author

epugh commented Feb 16, 2021

@michaelsuzukisagi I'd love your review.

@epugh
Copy link
Contributor Author

epugh commented Feb 17, 2021

I think I'm done with this PR! I'd love a review and then I'll commit it. I could see backporting it to 8.x as well.

Copy link
Contributor

@janhoy janhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to add a short credit to ui-grid in LICENSE.txt? I'm confused about when to use NOTICE and LICENSE, but I think it should go in one of them?

@epugh
Copy link
Contributor Author

epugh commented Feb 18, 2021

are you referring to the /solr/licenses/ directory? A /solr/licenses/ui-grid-LICENSE.txt and /solr/licenses/ui-grid-NOTICE.txt?

Be nice to add this to the dev docs!

@epugh
Copy link
Contributor Author

epugh commented Feb 18, 2021

also, I don't see any licenses for the JS libraries....

@epugh
Copy link
Contributor Author

epugh commented Feb 18, 2021

How do we get a clarificaiton on this?

@janhoy
Copy link
Contributor

janhoy commented Feb 18, 2021

So I think you add a few lines at bottom of solr/LICENSE.txt, you already see the jquery part there.
I have been adding some sections to solr/NOTICE.txt earlier, but I think some of those really belong in LICENSE.txt instead, since only some projects and licenses require use of NOTICE. So a cleanup is needed too...

@epugh
Copy link
Contributor Author

epugh commented Feb 18, 2021

ahh! I didn't know abouit that!

@epugh epugh merged commit f70a518 into apache:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants