Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-15156: [child childFilter='...:...'] no longer escapes #2367

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

dsmiley
Copy link
Contributor

@dsmiley dsmiley commented Feb 15, 2021

The query escaping it did was inconsistent with all other places in Solr where a Lucene query may be provided.

https://issues.apache.org/jira/browse/SOLR-15156

The query escaping it did was inconsistent with all other places in Solr where a Lucene query may be provided.
@dsmiley dsmiley requested a review from epugh February 15, 2021 05:34
Copy link
Contributor

@epugh epugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dsmiley dsmiley merged commit 253b20c into apache:master Feb 17, 2021
@dsmiley dsmiley deleted the solr-15156-child-childFilter branch February 17, 2021 03:37
dsmiley added a commit that referenced this pull request May 9, 2021
The query escaping it did was inconsistent with all other places in Solr where a Lucene query may be provided.
There was no escaping here prior to 8.0 either.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants