Skip to content

LUCENE-9322: Add Vectors format to CodecReader accounting methods #2353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2021
Merged

LUCENE-9322: Add Vectors format to CodecReader accounting methods #2353

merged 2 commits into from
Feb 11, 2021

Conversation

iverase
Copy link
Contributor

@iverase iverase commented Feb 11, 2021

Take into account the new Vectors format for methods:

  • ramBytesUsed
  • getChildResources
  • checkIntegrity

This has surfaced after #2331 as there are some test fails when nightly flag is true:

./gradlew :lucene:core:test --tests "org.apache.lucene.codecs.lucene90.TestLucene90VectorFormat.testRamBytesUsed" -Ptests.jvms=4 -Ptests.jvmargs=-XX:TieredStopAtLevel=1 -Ptests.seed=38AB1FFD5F1E45F6 -Ptests.nightly=true -Ptests.file.encoding=ISO-8859-1

@iverase iverase requested a review from msokolov February 11, 2021 14:03
@iverase iverase merged commit 683a9bd into apache:master Feb 11, 2021
@iverase iverase deleted the vectorAccounting branch February 11, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msokolov msokolov msokolov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iverase @msokolov