SOLR-15004: tests for the replica placement API + placement plugin fixes and light refactoring #2110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re accessible (and can be validated) in ClusterProperties. Fix a bug in update().
…g() to make it easier to debug / report. Improve test abstractions to make it easier to set up tests.
… states and collections
… into jira/solr-15004 (and make precommit happy)
…the affinity test.
… can be used in other placement tests (this required changing visibility of some classes / methods). Allow using the test framework random() for repeatable randomness.
…tingReplicas. There's a bug in AffinityPlacementPlugin
…plica pattern. Add a test.
… node when multiple AZ's have same number of replicas
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
|
|
||
| private final long prioritizedFreeDiskGB; | ||
|
|
||
| private Random random = new Random(); |
There was a problem hiding this comment.
PREDICTABLE_RANDOM: This random generator (java.util.Random) is predictable (details)
There was a problem hiding this comment.
This doesn't solve the issue but helps with tests, and it's a better method than adding a setter on AffinityPlacementPluginFactory:
static {
// We try to make things reproducible in the context of our tests by initializing the random instance
// based on the current seed
String seed = System.getProperty("tests.seed");
if (seed == null) {
RANDOM = new Random();
} else {
RANDOM = new Random(seed.hashCode());
}
}
(borrowed from OCMH)
| } | ||
|
|
||
| public static class RandomPlacementPlugin implements PlacementPlugin { | ||
| private Random random = new Random(); |
There was a problem hiding this comment.
PREDICTABLE_RANDOM: This random generator (java.util.Random) is predictable (details)
ctargett
pushed a commit
to ctargett/lucene-solr
that referenced
this pull request
Dec 16, 2020
…xes and light refactoring (apache#2110) Co-authored-by: Andrzej Bialecki <ab@apache.org>
epugh
pushed a commit
to epugh/lucene-solr-1
that referenced
this pull request
Jan 15, 2021
…xes and light refactoring (apache#2110) Co-authored-by: Andrzej Bialecki <ab@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Andrzej Bialecki ab@apache.org