Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LUCENE-9618: Do not call IntervalIterator.nextInterval after NO_MORE_DOCS returned #2095

Merged
merged 3 commits into from
Dec 3, 2020
Merged

LUCENE-9618: Do not call IntervalIterator.nextInterval after NO_MORE_DOCS returned #2095

merged 3 commits into from
Dec 3, 2020
+209 −2

Conversation

zhaih
Copy link
Contributor

@zhaih zhaih commented Nov 23, 2020

Description

  • In ConjunctionIntervalIterator check whether approximation's returned docId is NO_MORE_DOCS to avoid nextInterval() call after NO_MORE_DOCS is returned
  • Add a test case to verify the problem is addressed

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the master branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Ref Guide (for Solr changes only).

mikemccand
mikemccand approved these changes Nov 29, 2020
View reviewed changes
Copy link
Member

@mikemccand mikemccand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @zhaih -- nice catch, nice test case!

@mikemccand mikemccand merged commit f24b497 into apache:master Dec 3, 2020
ctargett pushed a commit to ctargett/lucene-solr that referenced this pull request Dec 16, 2020
@zhaih @ctargett
LUCENE-9618: Do not call IntervalIterator.nextInterval after NO_MORE_…
bbcf3a5 
…DOCS returned (apache#2095)

* LUCENE-9618: Do not call IntervalIterator.nextInterval after NO_MORE_DOCS is returned
epugh pushed a commit to epugh/lucene-solr-1 that referenced this pull request Jan 15, 2021
@zhaih
LUCENE-9618: Do not call IntervalIterator.nextInterval after NO_MORE_…
d33530d 
…DOCS returned (apache#2095)

* LUCENE-9618: Do not call IntervalIterator.nextInterval after NO_MORE_DOCS is returned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemccand mikemccand mikemccand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhaih @mikemccand