-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LUCENE-9391: Upgrade HPPC to 0.8.2 #1560
Conversation
Hi Patrick. Would you add a corresponding CHANGES entry (to both Solr and Lucene, I guess) and attribution to your name? Otherwise LGTM. |
@@ -10,7 +10,7 @@ com.carrotsearch.randomizedtesting.version = 2.7.6 | |||
|
|||
/com.carrotsearch.thirdparty/simple-xml-safe = 2.7.1 | |||
|
|||
/com.carrotsearch/hppc = 0.8.1 | |||
/com.carrotsearch/hppc = 0.8.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this then mean that Lucene's facet
module's usage of HPPC is upgraded too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so? In facet
's ivy.xml
it use rev="${/com.carrotsearch/hppc}"
which I believe is the variable here.
Thanks for reminding me that! Added! |
Hi Patrick, |
Oh, thank you for figuring that out! Yeah I picked up a wrong one from my backlog... Thank you very much! |
Do I need to squash the commits? Seems commits in Lucene are all squashed? Or it will be done automatically when merging somehow? |
Please do the "Squash and merge" below. |
Description
Upgrade HPPC to 0.8.2
ant test
passedant precommit
passedChecklist
Please review the following and check all that apply:
master
branch.ant precommit
and the appropriate test suite.