Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defer creation of locking model to ActivateOptions() #95

Merged
merged 2 commits into from
Oct 24, 2022

Conversation

FreeAndNil
Copy link
Contributor

@FreeAndNil FreeAndNil commented Oct 24, 2022

The creation of the locking model instance is now deferred to ActivateOptions() so that defaultLockingModelType has an effect.

  • include pdb file in nuget package fpr better debugging experience

@fluffynuts Could you please review?

@fluffynuts
Copy link
Contributor

@FreeAndNil most of the changes here are whitespace, except:

  1. not setting m_lockingModel at line 1660
  2. working around pdb files not being in the nuget package

I'm not 100% sure we want to expand the package size with the pdbs, considering the audience size of log4net. I'm open to be convinced here though (personally, since I use Rider, I can decompile any external sources enough to debug with, so pdbs have been of limited value). Please revert all the other files so that the impact is kept smaller.

@FreeAndNil
Copy link
Contributor Author

Hi @fluffynuts,

i've reverted all the spacing changes.

Regards

@fluffynuts fluffynuts merged commit b2ef9f6 into apache:master Oct 24, 2022
@FreeAndNil FreeAndNil deleted the Feature/LockingModel branch October 24, 2022 15:23
@FreeAndNil FreeAndNil added this to the 2.0.16 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants