Move site back where it belongs #62
Conversation
|
@rgoers I've moved the artifacts back where maven recognises them, but the result I get from running a command like |
|
FWIW, the Apache Logging project generally uses "CTR " (commit - then review). So if you are comfortable with the changes being made you don't need to create a PR. Committers generally only create PRs when they really want a code review because they either a) aren't 100% sure they are doing the right thing or b) want others to be aware of some impact the commit is going to cause. |
|
@rgoers I had 2 subsequent commits on the PR (didn't realise that you'd acted on it so quickly!) which restore the release folder in the site area, fixing all the missing artifacts that I found upon trying to build the site. Does CTR imply I should simply commit to master on apache/logging-log4net? |
|
On Aug 26, 2020, at 8:27 PM, Davyd McColl ***@***.***> wrote:
@rgoers <https://github.com/rgoers> I had 2 subsequent commits on the PR (didn't realise that you'd acted on it so quickly!) which restore the release folder in the site area, fixing all the missing artifacts that I found upon trying to build the site. Does CTR imply I should simply commit to master on apache/logging-log4net?
Yes, unless you specifically want others to review it because you aren’t quite sure if it is the right way to do it, the code will cause breaking changes and you want others opinions, etc. For most things you should just commit to master. We all get commit emails and will see it. Some of us might look at it and if we have questions we will ask.
Ralph
|
|
@rgoers cool -- but I can't push to apache/logging-log4net: |
|
Your apache userid is davydm. It needs to be linked with your GitHub user. See https://gitbox.apache.org/setup/. Apache Logging doesn't have a guide but many projects do. For example, https://cwiki.apache.org/confluence/display/OPENWHISK/Accessing+Apache+GitHub+as+a+Committer Ralph |
|
Thanks @rgoers I've managed to push & I've pushed new site content via svn too; getting a little stuck at point 7 of https://cwiki.apache.org/confluence/display/LOGGING/Managing+the+Logging+Services+Web+Site with respect to getting the site live |
|
I'm not sure if this belongs to the changes made in this PR, but https://logging.apache.org/log4net/ (with is the top Google result if you search for "log4net") currently leads to a directory listing. |
|
@cremor thanks for reporting; logging sites are in a bit of a state of upheaval right now (as far as I understand). Good people are On It. |
|
Please try it again. |
|
FWIW, the documentation for publishing the web site is at https://cwiki.apache.org/confluence/display/LOGGING/Managing+the+Git+Hosted+Web+Site. So you would run your build to create the web site and then copy it into the Log4net site repo. |
|
Thanks for sorting it out @rgoers. I'll try to be better prepared next time. |
|
@rgoers Now the link https://logging.apache.org/log4net/ works, but the link which is on https://logging.apache.org, which is https://logging.apache.org/log4net/2.x/index.html (both the button on the main site and in the menu at the top), doesn't work any more 😕 |
|
Thanks. Those should be fixed now. |
|
None of this was your fault. All these issues were related to me moving the site from the ASF CMS system to GitHub.
Ralph
… On Sep 10, 2020, at 9:50 AM, Davyd McColl ***@***.***> wrote:
Thanks for sorting it out @rgoers <https://github.com/rgoers>. I'll try to be better prepared next time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#62 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA5MX5JSB54TEOH4GJKN4DSFD7WFANCNFSM4QMCEMTA>.
|
This is work-in-progress: trying to get the log4net site generation working properly again.