Fix typo in LoggerConfig.RootLogger.Builder#withtFilter (#3369) #3372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a changelog entry (of type |
Generated by gradle/develocity-actions |
ppkarwasz
requested changes
Feb 16, 2025
log4j-core/src/main/java/org/apache/logging/log4j/core/config/LoggerConfig.java
Outdated
Show resolved
Hide resolved
26 tasks
|
Your two last commits are not signed and linked to the @jethomas-tsi account. Could you resign them, so I can merge the PR? git --force-rebase --gpg-sign origin/2.x
git push -fBTW: if you wait for the required checks to pass, feel free to merge this yourself. |
ppkarwasz
force-pushed
the
bugfix/LOG4J-3369
branch
from
1f38f1b to
78cc906
Compare
…der (apache#3369) Deprecated LoggerConfig.RootLogger.Builder#withtFilter(Filter). Added LoggerConfig.RoottLogger.Builder#withFilter(Filtter)
+ properly delegated from deprecated method to new method + updated affected package-info versions for baseline
* switched tests to use Builders instead of createLogger * changed new LoggerConig.RootLogger.Builder#withFilter to LoggerConfig.RootLogger.Builder#setFilter * deprecated LoggerConfig.Builder.withFilter and added LoggerConig.Builder.setFilter * moved changelog to correct .2.x.x directory
ppkarwasz
force-pushed
the
bugfix/LOG4J-3369
branch
from
78cc906 to
d496f03
Compare
The `o.a.l.l.core.async` package was modified indirectly: `AsyncLoggerConfig` inherited the changes to `LoggerConfig`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LoggerConfig.RootLogger.Builder: