Fix duplicate Dependabot PRs #3367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Dependabot cannot handle multiple versions of the same artifact at once, our Dependabot configuration for `2.x` is split into two runs: - One Dependabot run handles the dependency upgrades for the `log4j-slf4j-impl` (based on SLF4J 1.x) and `log4j-mongodb4` (based on MongoDB client 4.x). - A second Dependabot run handles the dependency upgrades for the remaining modules (which use SLF4J 2.x and MongoDB client 5.x). Unfortunately, due to the way Maven multi-module support is implemented in Dependabot (see dependabot/dependabot-core#222), the second Dependabot configuration also tries to upgrade the dependencies of `log4j-slf4j-impl` and `log4j-mongodb4`. This is due to the inclusion of the aggregator POM `/pom.xml`, which causes Dependabot to also include all the remaining Log4j modules. The easiest solution to this problem is to remove "/" from the second configuration. Pros: - 99% of our managed dependencies are in "/log4j-parent" or the individual modules, so we will not miss many upgrades. - No more duplicate PRs. Cons: - "pom.xml" contains some dummy managed dependencies to upgrade the version number of `commons-csv` and similar artifacts for **site-only** purposes. IMHO we should find a different way to upgrade these.
|
(KO’ed by flu. Responding from bed.)
Changes LGTM. I think we should later move the site from root to a leaf
module. This might help us to implement “site should run after all
modules”, which is a manual practice currently.
Op ma 6 jan 2025 om 15:22 schreef Piotr P. Karwasz ***@***.***
…
@ppkarwasz <https://github.com/ppkarwasz> requested your review on: #3367
<#3367> Fix duplicate
Dependabot PRs.
—
Reply to this email directly, view it on GitHub
<#3367 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAARTSOKS7QR4D33AEEKN332JKGQZAVCNFSM6AAAAABUVWOTOOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHAZDMNZWHA4TOMQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Get better soon!
I am glad you agree. Having a dedicated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Dependabot cannot handle multiple versions of the same artifact at once, our Dependabot configuration for
2.xis split into two runs:log4j-slf4j-impl(based on SLF4J 1.x) andlog4j-mongodb4(based on MongoDB client 4.x).Unfortunately, due to the way Maven multi-module support is implemented in Dependabot (see dependabot/dependabot-core#222), the second Dependabot configuration also tries to upgrade the dependencies of
log4j-slf4j-implandlog4j-mongodb4. This is due to the inclusion of the aggregator POM/pom.xml, which causes Dependabot to also include all the remaining Log4j modules. The easiest solution to this problem is to remove "/" from the second configuration.Pros:
Cons:
commons-csvand similar artifacts for site-only purposes. IMHO we should find a different way to upgrade these.