Skip to content

Add requiresLocation function for FailoverAppender #3257 #3259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2025
Merged

Add requiresLocation function for FailoverAppender #3257 #3259

merged 1 commit into from
Jan 6, 2025

Conversation

eldwrjwt
Copy link
Contributor

Fix #3257

  • Add requiresLocation implementation for FailoverAppender
  • Isolate LoggerContext for each test case in FailoverAppenderTest

@eldwrjwt eldwrjwt mentioned this pull request Nov 30, 2024
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2024 •
edited
Loading

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 ✅ Build Scan PUBLISHED
Generated by gradle/develocity-actions

@eldwrjwt
Copy link
Contributor Author

eldwrjwt commented Dec 4, 2024

Hi @ppkarwasz , would you like to review this PR, and #3257 if possible?

@ppkarwasz ppkarwasz self-assigned this Dec 4, 2024
@ppkarwasz
Copy link
Contributor

@eldwrjwt,

I am quite busy with my dayjob these days, but it is on my TODO list. Can you rebase the PR on the current 2.x? All the tests were migrated to JUnit 5, so there might be some conflicts.

@eldwrjwt
Copy link
Contributor Author

eldwrjwt commented Dec 4, 2024 •
edited
Loading

Sure, I have pushed a new commit, and it should have no conflict.

ppkarwasz
ppkarwasz approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ppkarwasz ppkarwasz mentioned this pull request Jan 6, 2025
Open
23 tasks
@ppkarwasz ppkarwasz merged commit 939599c into apache:2.x Jan 6, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppkarwasz ppkarwasz ppkarwasz approved these changes

Assignees

@ppkarwasz ppkarwasz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File line numbers are not printed for the failover appender when using AsyncLoggerContextSelector
2 participants
@eldwrjwt @ppkarwasz