Switch MongoDB tests to use Docker #2922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garydgregory
requested changes
Sep 6, 2024
Member
garydgregory
left a comment
garydgregory
left a comment
There was a problem hiding this comment.
Nice improvement @ppkarwasz 😀
Contributor
Author
Does it mean you approve? If not, what changes are you expecting? |
vy
requested changes
Sep 12, 2024
Member
vy
left a comment
vy
left a comment
There was a problem hiding this comment.
Locally verified the PR. Dropped some minor requests/questions.
Question: Will this get ported to 2.x?
I will align the <activation> of the docker profile of log4j-template-layout-json-test with this PR, once this gets merged.
log4j-mongodb/src/test/java/org/apache/logging/log4j/mongodb/MongoDbIT.java
Outdated
Show resolved
Hide resolved
log4j-mongodb/src/test/java/org/apache/logging/log4j/mongodb/MongoDbAuthFailureIT.java
Show resolved
Hide resolved
ppkarwasz
force-pushed
the
feature/main/2229_mongodb_docker
branch
from
c275e34 to
6a59e03
Compare
vy
approved these changes
Sep 13, 2024
vy
approved these changes
Sep 13, 2024
Contributor
Author
|
Oh, tests are stuck, it must be Friday 13th again! 😉 |
MongoDB is a binary server. The current `log4j-mongodb` tests download a **generic** binary MongoDB distribution and try to run it. The distribution is not self-contained and requires several libraries (e.g., OpenSSL) to be available on the target host. Those libraries are not always available in the required version: e.g., currently MongoDB needs OpenSSL 1, but OpenSSL 3 is bundled in the most recent Debian. This PR switches from the binary distribution to the usage of the **latest** Docker image available. The advantages of this approach are: - We always test against the newest server version available. - The success of the tests does not depend on the libraries installed on the host. - Tests can run in parallel. In the current approach, parallel tests failed since each one tried to download MongoDB separately. The main disadvantage is that Docker will be required to test `log4j-mongodb`. This is the case for the CI, but individual developers might need to install it too. Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
ppkarwasz
force-pushed
the
feature/main/2229_mongodb_docker
branch
from
b9e0df2 to
9cede69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MongoDB is a binary server. The current
log4j-mongodbtests download a generic binary MongoDB distribution and try to run it. The distribution is not self-contained and requires several libraries (e.g., OpenSSL) to be available on the target host.Those libraries are not always available in the required version: e.g., currently MongoDB needs OpenSSL 1, but OpenSSL 3 is bundled in the most recent Debian.
This PR switches from the binary distribution to the usage of the latest Docker image available.
The advantages of this approach are:
The main disadvantage is that Docker will be required to test
log4j-mongodb. This is the case for the CI, but individual developers might need to install it too.Fixes #2229.