Skip to content

Conversation

@grobmeier
Copy link
Member

@grobmeier grobmeier commented May 15, 2024

Rewrite of the Markers description, adding more information but also making the code example smaller

#2535

Ported to 3.x with: 891c08e

@grobmeier grobmeier requested a review from ppkarwasz May 15, 2024 22:09
@grobmeier grobmeier self-assigned this May 15, 2024
@grobmeier grobmeier mentioned this pull request May 15, 2024
5 tasks
grobmeier and others added 10 commits May 16, 2024 19:59
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
grobmeier and others added 6 commits May 20, 2024 17:59
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
Co-authored-by: Volkan Yazıcı <volkan@yazi.ci>
Co-authored-by: Piotr P. Karwasz <piotr.github@karwasz.org>
@ppkarwasz ppkarwasz requested a review from vy May 22, 2024 10:14
<root level="INFO"/>
<!-- tag::logger[] -->
<Logger name="example" level="ALL"><!--1-->
<logger name="example" level="ALL"><!--1-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct capitalization is Logger:

@Plugin(name = "Logger", category = Node.CATEGORY, printObject = true)

I did republish the XSD a couple of weeks ago, but apparently something is wrong with it (not the examples).

@grobmeier grobmeier merged commit 57c98de into 2.x May 22, 2024
@grobmeier grobmeier deleted the doc/2.x/manual-markers-2535 branch May 22, 2024 17:13
grobmeier added a commit that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants