Skip to content

Port log4j-jul changes from 2.x #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jan 5, 2024
Merged

Port log4j-jul changes from 2.x #2160

merged 14 commits into from
Jan 5, 2024

Conversation

ppkarwasz
Copy link
Contributor

We port the changes from 2.x that are missing from main:

  • the fix of LOG4J2-3634,
  • we remove ListAppender and use the version in log4j-core-test,
  • minor style changes.

@ppkarwasz ppkarwasz mentioned this pull request Jan 4, 2024
Closed
@ppkarwasz ppkarwasz self-assigned this Jan 4, 2024
@ppkarwasz ppkarwasz added this to the 3.0.0 milestone Jan 4, 2024
Piotr P. Karwasz and others added 14 commits January 5, 2024 15:41
@ppkarwasz
[LOG4J2-3564] Fix NPE when root logger level is null
5fcfb80 
`LogManager.getGlobal().getLevel()` is not a good fallback for the case
when all JUL logger levels are null, since its level is usually null.
@ppkarwasz
Sync 2.x and 3.x version of log4j-to-jul
9694b75
@ppkarwasz
Workaround Coursier/Ivy dependency resolution bug
51f7b82 
Workaround a Coursier/Ivy dependency resolution bug that affects
`log4j-slf4j-impl` and `log4j-mongodb3`.

This bug also affects popular sites like MvnRepository (cf.
[`log4j-mongodb3:2.22.0`](https://mvnrepository.com/artifact/org.apache.logging.log4j/log4j-mongodb3/2.22.0)).

Closes apache#2065
@ppkarwasz
Port log4j-slf4j-impl changes from 2.x
8ead919
@ppkarwasz
Fix BND baseline failure (log4j-slf4j-impl)
4c9ca59
@afs @ppkarwasz
Update exception message to refer to log4j-slf4j2-impl
ad95e90
@ppkarwasz
Fix BND baseline failure (log4j-slf4j2-impl)
7c5004c
@ppkarwasz
Port log4j-script changes from 2.x
b89d758 
This PR adds to the `log4j-script` module the missing changes from the `2.x` branch.

Since the module was created by moving classes from `log4j-core` the
comparison between branches must be done file by file.
@mknet @ppkarwasz
move the the code block to propagate to publish()
fe2609a 
in order to wait for the handlers to be registered in the root logger
@mknet @ppkarwasz
improve thread-safety
d267ef4
@mknet @ppkarwasz
make installAsLevelPropagator transient
c05af69 
see apache#1140 (comment)
@mknet @ppkarwasz
replace transient with volatile
519b00a
@mknet @ppkarwasz
add another check before we execute the synchronized code to propagate
865c908
@ppkarwasz
Port log4j-jul changes from 2.x
88d2899
@ppkarwasz ppkarwasz merged commit 88d2899 into apache:main Jan 5, 2024
@ppkarwasz ppkarwasz deleted the sync-jul branch January 5, 2024 16:21
@ppkarwasz ppkarwasz modified the milestones: 3.0.0, 3.0.0-beta2 Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vy vy vy approved these changes

Assignees

@ppkarwasz ppkarwasz

Labels
None yet
Projects
None yet
Milestone
3.0.0-beta2
Development

Successfully merging this pull request may close these issues.
4 participants
@ppkarwasz @vy @afs @mknet