Ports bnd-maven-plugin configuration to main
#1866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differences in the module descriptor: * `java.management` is added to the optional requires. Differences in the OSGi descriptor: * the import statement on `sun.reflect` disappears, * an import statement on `org.apache.logging.log4j.internal` appears.
The following packages are no longer exported: * org.apache.logging.log4j.core.layout.internal * org.apache.logging.log4j.core.message * org.apache.logging.log4j.core.time.internal * org.apache.logging.log4j.core.tools.picocli * org.apache.logging.log4j.core.util.internal A new JPMS module is generated, which sets the following Java modules as optional: * java.compiler, * java.logging, * java.naming, * java.sql. All the new 3.x modules are configured to use BND.
In order to prevent API breaking changes, this: * adds [`bnd-baseline-maven-plugin`](https://github.com/bndtools/bnd/tree/master/maven-plugins/bnd-baseline-maven-plugin), * fix the API changes that would require a major version bump, * set the OSGi version of each packages to `2.20.1` or `2.21.0`, depending on the kind of changes the package underwent since the `2.20.0` release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the necessary adjustments to port #1819 to the
mainbranch.Except the changes that were already performed in
2.xit:module-info.javadescriptors: they will be replaced by automatically generated ones,META-INF/servicesentries: they will be generated by BND; some of the entries remain since the current BND configuration addsMETA-INF/servicesdirectly to the JAR, so they are invisible to the tests. We can change that.This is part of #1830 and #1705.