-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[log4j-to-slf4j] Adapt OSGi metadata to work with slf4j 1 and 2 #1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks good to me. Can you only rename the changelog file? The convention we use is |
9bb7199
to
54679b6
Compare
Thanks for the hint, I didn't recognize that before. Adjusted the name accordingly. |
Use the version range [1.7,3) for the imported slf4j packages. See also https://bnd.bndtools.org/macros/range.html Fixes apache#1232 Signed-off-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
54679b6
to
5bbfa41
Compare
Thank you for your contribution, it's merged. When Windows decides to build, a snapshot will be generated. |
Great. Thank you for your quick review. Out of curiosity, do you already have plans for the next release? |
Another thing, do you think this change should be back-ported to the main branch? |
We try to release every 3 months, unless something important comes up. Since the last release is from February 22th, I would expect a release soon. We'll take care of porting your changes to |
Great. Thanks for the info and back-porting. 👍🏽 |
@ppkarwasz can you give any update about the plan for a 2.20.1 or 2.21.0 release? Thanks in advance. |
Use the version range
[1.7,3)
for the imported slf4j packages.See also https://bnd.bndtools.org/macros/range.html
This changes the generated OSGi
Import-Package
entries in the MANIFEST.MF fromto
Besides the order, which is irrelevant, only the import package version is changed to [1.7,3) as desired.
I also created a change-log entry as requested by the checklist and hope that is fine.
@ppkarwasz please let me know if any changes are required. Thank you.
Fixes #1232
Checklist
2.x
branch if you are targeting Log4j 2; usemain
otherwise./mvnw verify
succeeds (if it fails due to code formatting issues reported by Spotless, simply runspotless:apply
and retry)src/changelog/.2.x.x
directory